Add support for modern social share platforms.#15959
Conversation
The upstream library was abandoned, but it still works with some tweaking. I'm not truly convinced of the utility of share icons anymore, but if they're there then I want to use the modern platforms.
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Which is why I never got around to doing what you did, so thanks! :) |
|
I don't think these new icons or share buttons get used anywhere? I can take a look and figure out because I think the event main page needs to know about them |
|
OK, looking at it. It should just work, but when I look in the deploy preview, I don't see the new buttons. |
|
I did not change the default set. I figured the safer approach would be to make them available first so events could opt in to using them. Then at some point in the future we could rethink the default set of icons. |
|
cool, just wanted to make sure I tested it properly! lgtm |
2 participants
The upstream library was abandoned, but it still works with some
tweaking. I'm not truly convinced of the utility of share icons
anymore, but if they're there then I want to use the modern platforms.